search

libgit2 / libgit2sharp

Git + .NET = ❤
http://libgit2.github.com
MIT License
3.12k stars 878 forks source link

Add CustomHeaders to PushOptions #2052

Closed James-LG closed 8 months ago

James-LG commented 11 months ago

Wires up CustomHeaders in PushOptions in the same vein as FetchOptions.

Libgit2 already supports CustomerHeaders on PushOptions, so might as well hook it up. Plus it's required for some git servers that require strange PAT token formats like Azure DevOps #2041.

This PR is similar to #2011 except it properly disposes the managed string array and it has some tests.

evolvedlight commented 8 months ago

Any chance this could be merged? I'm currently maintaining a custom fork with this but this would allow me to delete it.

James-LG commented 8 months ago

I would love to merge it, but it doesn't seem like the maintainers are very active unfortunately.

jhested commented 8 months ago

I also need this :). How can we get it in?

JBrejnholt commented 8 months ago

@bording are you going to merge this change soon?

kristianbjensen commented 8 months ago

I need this aswell

bording commented 8 months ago

@James-LG Go ahead and take out the devcontainer stuff, and then I'll give this a review and get it merged and released this weekend.

James-LG commented 8 months ago

Thanks! Devcontainers removed.

bording commented 8 months ago

This has been released in LibGit2Sharp 0.28.0.

jhested commented 8 months ago

That is awesome @bording. Thanks for taking the time to merge this