"remote authentication required but no callback set" in pull after upgrading from 0.28 to 0.29

FreeAndNil commented 3 months ago

@bording we get the error "remote authentication required but no callback set" after upgrading from 0.28 to 0.29 when connecting to a company internal azure devops server.

This works great with the old version using windows authentication.

Reproduction steps

connect to a company internal azure devops server via windows authentication

  Signature signature = GetSignature();
  PullOptions pullOptions = new()
  {
    MergeOptions = new() { FileConflictStrategy = CheckoutFileConflictStrategy.Theirs }
  };
  MergeResult mergeResult = Commands.Pull(Repository, signature, pullOptions);

Expected behavior

Success

Actual behavior

LibGit2Sharp.LibGit2SharpException HResult=0x80131500 Message=remote authentication required but no callback set Source=LibGit2Sharp StackTrace: at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in /_/LibGit2Sharp/Core/Ensure.cs:line 154

Version of LibGit2Sharp (release number or SHA1)

0.29

Operating system(s) tested; .NET runtime tested

Windows 11, .NET 4.8

Seems to be related to #2065 and #2087

mezzo1981 commented 1 month ago

Hi, any update on this ? we have the same issue...

FreeAndNil commented 3 weeks ago

@bording is there any chance of fixing this?

bording commented 3 weeks ago

@bording is there any chance of fixing this?

To have any chance of it getting fixed, I would need a way to reproduce it. I can't connect to your company internal azure devops server via windows authentication, so that's rather tricky.

FreeAndNil commented 3 weeks ago

@bording I could try to reproduce it on a azure VM where I could grant you access. Would this be an option for you?

bording commented 3 weeks ago

@bording I could try to reproduce it on a azure VM where I could grant you access. Would this be an option for you?

That would at least let me see the failure happening myself, but ideally there would be a way to run some reproduction code under a debugger to really see what was going on.

The best way forward here would be if a failing test could be added to the repo to demonstrate the problem, though I don't immediately know how that might be achieved since you're saying Windows auth is a requirement.

libgit2 / libgit2sharp