Git notes

[slavikus]

Adding support for Git Notes already supported in libgit2. A new class, GTNote has been added, along with a few methods for GTRepository to create and remove notes, as well as push them to remotes.

[tiennou]

Review complete. There are a few "open questions" here but apart from that and a few style points, it looks good, thanks !

[slavikus]

Submitted the fixes per @tiennou feedback.

[pietbrauer]

Closed and reopened for Travis to pick it up again.

[pietbrauer]

@slavikus Could you rebase this onto master, somehow the tests failed but master seems to be stable so far.

[slavikus]

There you go, @pietbrauer :)

[pietbrauer]

There is an open question by @tiennou https://github.com/libgit2/objective-git/pull/576#discussion_r63961775.

@tiennou can decide when to merge, tests are green now.

[slavikus]

@tiennou any insight whether this pull request should be accepted or not? :)

[tiennou]

Sorry, I've put my styleguide-master hat on :wink:. There are a few *-spacing issues I didn't explicitly comment on though. And the new -pushBranches:...withNotesReferenceName: I'm not fond of.

@pietbrauer I feel the responsibility 😨. I'm concerned about the libgit2 "bump" though, but I'm confused because the merge is still green which I did not expect. Current master tracks 0.24.1, but it wasn't at the time, hence the 1st commit.

[slavikus]

Wow, @tiennou , thanks for taking your time to review this. I'll fix the style stuff tomorrow, and will wait for the pushBranches decision. After some thought, maybe options is the way to go, yep.

I'll also try and merge with the most recent stuff in master.

[slavikus]

@tiennou nudge nudge? :)

[tiennou]

There's a few things left, and a few things I missed the first time around.

• A test exercising note-pushing might be nice. I was wondering what would happen in case I specified a non-existent note-ref name.
• We still don't have a clear answer on the pushBranches thing, and I'd like some feedback from someone else. My preference would be for a new GTRepositoryRemoteOptionsPushNotes, with either a @(BOOL) which pushes the default note-ref, of an array of reference names.

[tiennou]

Also, does the PR really depend on the libgit2 bump ? I'm still concerned about that...

@pietbrauer Insight needed please !

[pietbrauer]

Does not seem necessary to me.

[slavikus]

@tiennou I appreciate the time and effort you put into this, can you please check the changes? :)

[tiennou]

A few minor comments still.

I'm slightly concerned about that lookup/use-oid issue there seem to be, but I don't feel my git-fu is sufficient to tell whether it's right or wrong to not use (arguably, libgit2 has no API for grabbing a note by its OID directly)... For the record, it seems notes are just blobs, so a GTObject-lookup for that would do, but that's just a hunch.

[slavikus]

Sadly, there's no API in libgit2 to grab by note's OID directly, so that's why we have to go the other way 'round.

Fixed most other notes and nitpicks, aside for the whitespace issue I don't see. :)

[slavikus]

Travis build for macOS seems to be failing for some reason beyond the code of this pull request.

[tiennou]

A local run of the tests (both iOS & Mac) are green, so merging in. Thanks for the PR @slavikus !

[slavikus]

Thank you, appreciate your patience and feedback on this, guys!