libgit2 / php-git

PHP bindings for libgit2
http://libgit2.github.com
MIT License
563 stars 118 forks source link

README instructions for compiling #65

Open MagicalTux opened 10 years ago

MagicalTux commented 10 years ago

The "how to build" instructions in the readme file will probably work fine on 32bits machines, however compiling a static version of libgit2 to then compile a dynamic php module will not work (linker will complain about -fPIC).

Easy fix by replacining line cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_SHARED_LIBS=OFF -DBUILD_CLAR=OFF .. with: cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_SHARED_LIBS=OFF -DBUILD_CLAR=OFF -DCMAKE_C_FLAGS=-fPIC ..

duguying commented 10 years ago

:+1: i have the same question

smalot commented 10 years ago

Mark is back ! ;-) Nice to see you again