search

libgit2 / pygit2

Python bindings for libgit2
https://www.pygit2.org/
Other
1.59k stars 383 forks source link

libgit2 1.2.0 support #1090

Closed alyssais closed 2 years ago

alyssais commented 2 years ago

Hi, I'm a Nixpkgs developer, and we'd like to update the version of libgit2 that we're providing to 1.2.0, which was recently released. But doing this would break every package that uses pygit2:

#error You need a compatible libgit2 version (1.1.x)

Do you have plans for a new release that is compatible with libgit2 1.2.x? Thanks!

Mindavi commented 2 years ago

See #1089 for someone working on it.

alerque commented 2 years ago

Same problem here for Arch Linux. Almost everything else using libgit2 is rebuilt, but this is holding up anything from actually going through.

herbygillot commented 2 years ago

And now v1.3.0 of libgit2 has just been released: https://github.com/libgit2/libgit2/releases

alerque commented 2 years ago

@herbygillot This was fixed in Git HEAD (see #1089) but they haven't done a release yet.

To anybody maintaining this: Tagging a new release is the only way to relieve the pain downstream.

For others still running into this with tagged releases, the guys over at Homebrew cooked up this pactch that also worked for Arch Linux packaging to get the last tagged pygit2 release to run against current libgit2 builds.

carlocab commented 2 years ago

Here's a patch for 1.3.0 for the PyPI tarball: https://raw.githubusercontent.com/Homebrew/formula-patches/54d3a0d1f241fdd4e9229312ced0d8da85d964b1/pygit2/libgit2-1.3.0.patch

herbygillot commented 2 years ago

Thank you @alerque, @carlocab.