search

libgit2 / pygit2

Python bindings for libgit2
https://www.pygit2.org/
Other
1.61k stars 385 forks source link

ci: use cibuildwheel and GHA to build Windows wheels #1171

Open skshetry opened 1 year ago

skshetry commented 1 year ago

It might be easier to add support for future Python versions if we migrate.

gdubicki commented 1 year ago

+1.

Missing wheels for Python 3.11 and Windows is blocking adding Python 3.11 support for tsrc (see fail in https://github.com/your-tools/tsrc/pull/373).

I tried to quickly hack and build this myself but run into a problem with (seemingly) logging the actual wheels build error to the console, see https://github.com/gdubicki/pygit2/actions/runs/3507552353/jobs/5875340985 if you are interested.

But I am supper happy to see that work on this is already in progress in https://github.com/libgit2/pygit2/tree/fixwheels. Thank you, @jdavid ! :)

skshetry commented 1 year ago

@gdubicki, pygit2==1.11.1 already has wheels built for Windows + 3.11. I see that in CI, it is installing 1.10.1 which does not have required wheels. Please try upgrading. See https://github.com/libgit2/pygit2/pull/1177.

This issue is proposing to use GitHub Action to build wheels instead of currently using appveyor.

gdubicki commented 1 year ago

Thanks a lot @skshetry! I misinterpreted this issue and the current contents of https://github.com/libgit2/pygit2/blob/master/.github/workflows/wheels.yml where there is no Windows. My issue is resolved. :)