search

libgit2 / rugged

ruby bindings to libgit2
MIT License
2.24k stars 277 forks source link

add Credentials::SshKeyMemory (off v1.5.0.1) #956

Open tjk opened 1 year ago

tjk commented 1 year ago

GitHub is not letting me create this PR against v1.5.0.1 which is the tag I branched off of...

Edit 1: looks like need to ensure libgit2 is compiled with GIT_SSH_MEMORY_CREDENTIALS defined...

Edit 2: this may just be because it couldn't find libssh2 shared libs...

//Have library /usr/local/lib/libssh2.dylib
HAVE_LIBSSH2_MEMORY_CREDENTIALS:INTERNAL=1

Edit 3: ^ correct, this feature is disabled if libssh2 shared libs are not found (was previously building static). Not sure how to enforce or check in rugged... looking for guidance but at least for my use case this works.

tjk commented 1 year ago

Need to track why but I actually think this is the cause of https://github.com/libssh2/libssh2/issues/1107... looking to see if it's something obvious.