search

libglui / glui

GLUI is a GLUT-based C++ user interface library which provides controls such as buttons, checkboxes, radio buttons, and spinners to OpenGL applications. It is window-system independent, using GLUT or FreeGLUT.
Other
194 stars 82 forks source link

Code tidy-up: void parameters not needed in C++ #65

Closed nigels-com closed 7 years ago

nigels-com commented 7 years ago

For slightly modernising the GLUI codebase, omit void for parameterless functions and methods.

josch commented 7 years ago

The commit has an unrelated change it it: the replacement of the sourceforge url with the github url. Maybe you want to make this two commits.

nigels-com commented 7 years ago

Sure, no problem.

nigels-com commented 7 years ago

Hey @josch any further concerns on this one? I'm happy to circle back with another PR to update the links in the comments.

josch commented 7 years ago

Oh, I thought that you already pressed the "rebase and merge" button yoursefl. Didn't I give you permissions for that recently?

nigels-com commented 7 years ago

@josch I have permission to rebase and merge into master, would you prefer I rolled stuff into master without your input?

josch commented 7 years ago

If you want my input then I gladly give it to you but glui is your baby and your contributions have always been top notch and I cannot remember having disagreed with you on any technical opinion of yours. So if it makes your life easier, then I wouldn't mind you pushing directly to master. :)

Sometimes my slow reply are due to me being tied up in my doctoral thesis which I have to compose within the next year and that unfortinately limits the time I can spend on glui (even though glui is part of the stuff I'm working on as part of my thesis).

Thanks!