search

libgme / game-music-emu

Blargg's video game music emulation library, which allows audio applications to easily add playback support for the music of many classic video game consoles.
GNU Lesser General Public License v2.1
68 stars 12 forks source link

zlib linking on MinGW, missing -lz in pkg config? #17

Closed Wohlstand closed 6 years ago

Wohlstand commented 6 years ago

Original report by Anonymous.

Since the recent addition of zlib this project can't be linked to anymore, complaints it misses zlib functions. Seems like you forgot to add zlib to the pkg-config file, manually adding -lz to libgme.pc fixes the build, but this should be fixed on your end I assume.

Wohlstand commented 6 years ago

Original comment by Michael Pyne (Bitbucket: mpyne, GitHub: mpyne).

Thanks for the report, yes probably something I need to fix.

Is this happening with a static build? Everything I've been reading implies that linking to a dynamic libgme.so (or libgme.dll) should already pull in zlib at link-time since the dynamic lib itself is linked to zlib.

Wohlstand commented 6 years ago

Original comment by Michael Pyne (Bitbucket: mpyne, GitHub: mpyne).

Add pkg-config metadata for linking to zlib with static builds.

This should fix issue #15. I think.