search

libgme / game-music-emu

Blargg's video game music emulation library, which allows audio applications to easily add playback support for the music of many classic video game consoles.
GNU Lesser General Public License v2.1
70 stars 13 forks source link

Why is UBSan enabled by default? #52

Closed drfiemost closed 1 year ago

drfiemost commented 1 year ago

I'd say it should be off for normal builds. If any it could be enabled when build type is Debug.

https://github.com/libgme/game-music-emu/blob/2212cdff42b5605d0191e743bf51299643dc2a55/CMakeLists.txt#L67C20-L67C20

Wohlstand commented 1 year ago

You right, ASAN/UBSAN should be enabled manually only for debugging only. In my main projects I already do that.

Wohlstand commented 1 year ago

Quickly fixed this.