guard Ym2612* sources properly

libgme / game-music-emu

Blargg's video game music emulation library, which allows audio applications to easily add playback support for the music of many classic video game consoles.

GNU Lesser General Public License v2.1

59 stars 12 forks source link

guard Ym2612* sources properly #72

Closed sezero closed 8 months ago

sezero commented 8 months ago

This helps with standalone makefiles, such as Android.mk to include all those Ym2612* sources. Also error out if more than one VGMYM2612??? macro is defined.

Wohlstand commented 8 months ago

Guards are good, but better to don't add them into build to:

Don't cause "object has no symbols" warnings spam on macOS.
Don't spend time on files are just "empty".

At Android.mk that could be fine, at CMake better to keep them not always included.

sezero commented 8 months ago

OK, dropped cmake parts and adjusted commit message

Wohlstand commented 8 months ago

Anyway, I think, I'll rework this and I will make the ability to dynamically select an emulator (like libADLMIDI / libOPNMIDI allows to do).