libgme / game-music-emu

Blargg's video game music emulation library, which allows audio applications to easily add playback support for the music of many classic video game consoles.

GNU Lesser General Public License v2.1

59 stars 12 forks source link

Planning the 0.6.4 release #75

Open Wohlstand opened 8 months ago

Wohlstand commented 8 months ago

I think, it's a time to release the version 0.6.4 very soon, as it seems very stable now.

I think, there is only one small thing left: merge #54 and update the documentation and notes to ensure everything is fine.

If there are any serious issues left, let's add them into the milestone #1 and resolve them until make a release?

@sezero, what do you think yourself?

After the 0.6.4 release, I want to start some bigger updates like reworking the VGM backend and other parts. That will be a big update, and before to start these works, it's reasonable to release the current version as a stable.

Previous stable version was out a while ago and no new versions had been released after that time.

Plan for 0.6.4 release:

[x] Merge #54 and give a note about the logic change of the multichannel support.
[ ] #58 Verify the old version of 0.6.3 to try reproduce the crash and compare with latest version to see, was that problem got been fixed or not.
[ ] Before the release, add a note about the behaviour change after #58.

sezero commented 8 months ago

I think, it's a time to release the version 0.6.4 very soon, as it seems very stable now.

Yes

I think, there is only one small thing left: merge #54 and update the documentation and notes to ensure everything is fine.

Yes

There is #58 but I don't know whether it is still an issue

sezero commented 8 months ago

Also: Is unrar support truly necessary in library side? IMO, such things should be handled in player programs, not library. (I won't fight for it though.)

Wohlstand commented 8 months ago

By default, unrar support is disabled. Do you think I should remove it from the library side before 0.6.4 release? (do a small part of work doing in #74)

sezero commented 8 months ago

By default, unrar support is disabled.

Unfortunately no, it is enabled by default

Do you think I should remove it from the library side before 0.6.4 release?

Possibly yes: If nothing else, unrar is a 'non-free' code.

(do a small part of work doing in #74)

Yes, unrar support can be further worked there, preferably in player side

Wohlstand commented 8 months ago

Unfortunately no, it is enabled by default

Damn... I think, I missed something, ye, I see, it's enabled.

Wohlstand commented 8 months ago

Yes, unrar support can be further worked there, preferably in player side

Ye, anyway, to be quick, I'll just set it disabled by default with adding a warning that this library is unfree.

Wohlstand commented 8 months ago

Done, I disabled it by default.

myQwil commented 8 months ago

74 now removes unrar from the library end and re-implements it as an optional feature for the player.

Wohlstand commented 8 months ago

P.S. I forgot to append some: the 0.6.4 version I want to be a kind of a checkpoint release, because after it, I going to start some other works like improvements of the VGM support and other things.

sezero commented 8 months ago

0.6.4 version I want to be a kind of a checkpoint release,

Do you want #74 in 0.6.4 then? At least in minimal form which moves unrar support from library to player side?

Wohlstand commented 8 months ago

Do you want https://github.com/libgme/game-music-emu/pull/74 in 0.6.4 then? At least in minimal form which moves unrar support from library to player side?

Would be good, yeah.

sezero commented 8 months ago

Do you want #74 in 0.6.4 then? At least in minimal form which moves unrar support from library to player side?

Would be good, yeah.

PING @myQwil then..

myQwil commented 8 months ago

It's basically done. The zip reader doesn't read .vgz files in .zip files as that's a 2nd layer of compression. You could always decompress the .vgz files individually and then repackage them in a new zip file.

myQwil commented 8 months ago

If you like, I can take out the zip reader for the time being.

Wohlstand commented 8 months ago

If you like, I can take out the zip reader for the time being.

Ye, you could make a shot for that.

sezero commented 7 months ago

@Wohlstand: As far as I can see, #74 is ready for merging for 0.6.4

Wohlstand commented 7 months ago

Going to review this as soon as possible.

Wohlstand commented 6 months ago

Some news: Sorry for the monthly delay, I was ill (possibly because of a new kind of flu that gets spread around: several of my buddies from different cities or even countries, also ill) and therefore, I was being mostly unavailable. I going to resume any works very soon and finish the existing stuff.

sezero commented 6 months ago

Sorry for the monthly delay, I was ill

Great that you recovered!

Wohlstand commented 1 hour ago

About the #58, I actually found the reason of the problem, and I reproduced it locally on my Linux Mint, I had to build the latest VLC from the source code (the current version of VLC 3.0.16 at my Mint 21.3 doesn't triggers the problem, but the latest 3.0.20 built from the source does). I guess, after closing it, I can finally perform a release of 0.6.4 and start bigger works over the VGM thing.