go back to the v0.6.3 solution for VS2015 static_assert workaround

libgme / game-music-emu

Blargg's video game music emulation library, which allows audio applications to easily add playback support for the music of many classic video game consoles.

GNU Lesser General Public License v2.1

59 stars 12 forks source link

go back to the v0.6.3 solution for VS2015 static_assert workaround #90

Closed sezero closed 3 months ago

sezero commented 3 months ago

Notes: There are the following plain static_asserts that you did not change with your VS2015 patch: Do they not need changing?

Kss_Cpu.h at line 45
Ay_Cpu.h at line 36
Effects_Buffer.cpp at lines 35 and 39
Fir_Resampler.h at line 81
Gb_Cpu.cpp at line 117

(And also player/Audio_Scope.cpp at line 31)

Wohlstand commented 3 months ago

Notes: There are the following plain static_asserts that you did not change with your VS2015 patch: Do they not need changing?

Actually they don't need. The reason of the workaround is because of special condition with the static assert that happens with MSVC 2015 and older in given places, but in other cases it just works. That why these static assets wasn't changed into workaround.

sezero commented 3 months ago

Notes: There are the following plain static_asserts that you did not change with your VS2015 patch: Do they not need changing?

Actually they don't need. The reason of the workaround is because of special condition with the static assert that happens with MSVC 2015 and older in given places, but in other cases it just works. That why these static assets wasn't changed into workaround.

OK then

Wohlstand commented 3 months ago

Okay, I merged the thing and tweaked some at the end.