search

libgraviton / php-rql-parser

A PHP RQL Parsing Library
15 stars 4 forks source link

Refactor LogicExection to SyntaxErrorException #29

Closed hairmare closed 9 years ago

lapistano commented 9 years ago

sometimes I don't understand Scrutinizers' reports .. seems something we already declared as to be excluded from duplication check popped up again ...

hairmare commented 9 years ago

It seems scrutinizer was still taking the duplication into account when rating the code even after we ignored the issue. As in most cases scrutinizer was right about the need to refactor so i did #30