libguestfs / libguestfs-common

Common code shared between libguestfs and tools
4 stars 4 forks source link

Issues building libguestfs #4

Closed sbneto closed 2 years ago

sbneto commented 2 years ago

I am getting errors when trying to build from current master

#16 367.1 make[2]: Entering directory '/opt/libguestfs/common/utils'
#16 367.1   CC       libutils_la-cleanups.lo
#16 367.1   CC       libutils_la-environ.lo
#16 367.1   CC       libutils_la-gnulib-cleanups.lo
#16 367.1   CC       libutils_la-libxml2-cleanups.lo
#16 367.1   CC       libutils_la-pcre2-cleanups.lo
#16 367.1   CC       libutils_la-stringlists-utils.lo
#16 367.1   CC       libutils_la-utils.lo
#16 367.1 environ.c:40:10: fatal error: nbdkit-plugin.h: No such file or directory
#16 367.1    40 | #include <nbdkit-plugin.h>
#16 367.1       |          ^~~~~~~~~~~~~~~~~
#16 367.1 compilation terminated.
#16 367.1 make[2]: *** [Makefile:765: libutils_la-environ.lo] Error 1

I can see recent changes that are related to this error here https://github.com/libguestfs/libguestfs-common/blame/3c64bcdeaf684f05f46f3928b55aadafdfe72720/utils/environ.c#L40

Any pointers on this are appreciated.

rwmjones commented 2 years ago

Yeah that's a mistake, you can just delete that #include. I'll fix it shortly.