rwmjones
commented
6 months ago Sure, we can drop AUR if you like. Are there other packages which are not in the base Arch distribution that we need?
Open dvzrv opened 6 months ago
rwmjones
commented
6 months ago Sure, we can drop AUR if you like. Are there other packages which are not in the base Arch distribution that we need?
dvzrv
commented
6 months ago That's a good question. Where do I need to look to find out?
Are these the relevant blocks? https://github.com/libguestfs/libguestfs/blob/6ba64125d960c820b75727e3856b0df0ed6b264c/appliance/packagelist.in#L99-L123 https://github.com/libguestfs/libguestfs/blob/6ba64125d960c820b75727e3856b0df0ed6b264c/appliance/packagelist.in#L243-L298
I know that e.g. zerofree is not packaged for the official repos, but it doesn't appear to be built from the AUR (see https://gitlab.archlinux.org/archlinux/packaging/packages/libguestfs/-/issues/1).
Could you explain which of the packages are hard dependencies?
rwmjones
commented
6 months ago Yes it's those. Supermin actually ignores packages that it doesn't know about (by design), so it's rather hard to know which ones are really required and which aren't. A number of them will just enable optional features in libguestfs but it'll work without them.
zerofree is definitely not important.
I was just wonder if there are major packages in AUR which are not in base Arch that we should know about, however if not I guess we can just try it.
dvzrv
commented
6 months ago Yes it's those.
Just to make sure: Are all those pkgs only build time dependencies? With libguestfs I always had a hard time figuring out what is build time and what is runtime dependency :S
dvzrv
commented
6 months ago The following dependencies do not exist (neither in the official repositories nor in the AUR):
The following only exist in the AUR:
rwmjones
commented
6 months ago Yes it's those.
Just to make sure: Are all those pkgs only build time dependencies? With libguestfs I always had a hard time figuring out what is build time and what is runtime dependency :S
They're both. Libguestfs builds a skeleton appliance and fills it in with files from the host filesystem at runtime (https://rwmj.wordpress.com/2014/03/08/supermin-version-5/).
Looking at the list above, I would say the only one which is important is util-linux{-ng}. I'm sure you must be packaging util-linux-ng, but probably it's been renamed as util-linux. Old util-linux was deprecated years ago. (https://en.wikipedia.org/wiki/Util-linux)
Hi! :wave:
I package libguestfs for Arch Linux. When investigationg https://github.com/libguestfs/libguestfs/issues/139 I noticed the following:
This appears to be implemented in https://github.com/libguestfs/supermin/blob/5a44ffc68f6eb2906e761dad63dcd207b5ca607a/src/ph_pacman.ml#L196-L234
Frankly, this is quite the horrific approach. The AUR is unsupported for a reason and should never be used in the context of distribution packages. In this particular case supermin attempts to build a package that is available in the repositories (cdrtools), but not in the AUR.
If the packages can not be retrieved, the build process should not fall back to building from unverified and untrusted sources but instead just fail! To be more specific: Please do not automatically build from the AUR at all!