[EMTC] Implemented Major Output Calculations + Motor Torque Graph

libhal-google / webtools

A tools to help with calculations for embedded software development, robotics, electrical engineering with the goal of being easy to use, interactive, and sharable,

Apache License 2.0

1 stars 5 forks source link

[EMTC] Implemented Major Output Calculations + Motor Torque Graph #22

Open htran381 opened 1 year ago

htran381 commented 1 year ago

Implemented Max Torque, Max Current, Max Power, RPM @ Limited, and Power @ Limited Outputs.
Added Motor Torque Graph via Plotly
Added Missing Input: Target Torque

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

kammce commented 1 year ago

Thanks Hannah! You'll need to sign the google CLA before we can evaluate your PR.

htran381 commented 1 year ago

I've signed the CLA and it won't give a passing check despite the amount of times I've had this PR rescanned. Would I need to close this PR and do another one for it to work?

kammce commented 1 year ago

I've signed the CLA and it won't give a passing check despite the amount of times I've had this PR rescanned. Would I need to close this PR and do another one for it to work?

Sounds good. Are you sure you are signing the CLA with the email associated with your github? If not, you'll need to add that email to your github.

htran381 commented 1 year ago

Yup! I made sure my github email is the same on the CLA.

kammce commented 1 year ago

I can work with you to figure out the CLA issue whenever you have time. Message me on discord your availability.