search

libhal / SJSU-Dev2

Firmware platform written by San Jose State University for building application for embedded systems
Apache License 2.0
42 stars 63 forks source link

Fix always succeeding brew install #1424

Closed kammce closed 3 years ago

kammce commented 3 years ago

A misplaced assignment of a local variable, in this case brew_install=0, will always result in $? returning 0 which will always succeed. This needs to be fixed to make sure that $? is referring to which -s brew.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1424 (a9a906d) into master (94ab6fe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1424   +/-   ##
======================================
  Coverage    59.1%   59.1%           
======================================
  Files          94      94           
  Lines        4598    4598           
  Branches      980     980           
======================================
  Hits         2713    2713           
  Misses       1627    1627           
  Partials      258     258

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94ab6fe...a9a906d. Read the comment docs.