Closed kammce closed 3 years ago
Merging #1449 (20dcd64) into master (e2285c1) will decrease coverage by
0.2%
. The diff coverage is27.3%
.
@@ Coverage Diff @@
## master #1449 +/- ##
========================================
- Coverage 60.0% 59.8% -0.1%
========================================
Files 94 94
Lines 4507 4516 +9
Branches 968 970 +2
========================================
- Hits 2701 2699 -2
- Misses 1578 1588 +10
- Partials 228 229 +1
Impacted Files | Coverage Δ | |
---|---|---|
library/peripherals/lpc40xx/system_controller.hpp | 56.4% <ø> (ø) |
|
library/peripherals/lpc40xx/uart.hpp | 61.7% <27.3%> (-6.8%) |
:arrow_down: |
library/peripherals/lpc17xx/system_controller.hpp | 93.3% <0.0%> (+0.6%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e2285c1...20dcd64. Read the comment docs.
Use a constexpr table of baudrate fractional dividers and simplify parts of the baud rate calculation.
Replace broken fractional divider estimation, which genearted values above and below 1.1 and 1.9, with table which ensure that the values within are either 0 or 1.1 to 1.9.
Fix issue with sjsu::lpc40xx::SetMaximumSpeed() where it can cause problems with interrupts. Now it will disable interrupts during the system speed transition.
Fix issue with esp8266 demo where there is a print statement between the socket write and socket read which, for devices without UART DMA support results in missing data the length of time the print occurs.