libhangul / ibus-hangul

The hangul engine for IBus
GNU General Public License v2.0
65 stars 18 forks source link

Release a new version of ibus-hangul #52

Closed fujiwarat closed 6 years ago

fujiwarat commented 6 years ago

I think the git master uses ibus_engine_forward_key_event() but ibus-hangul 1.5.0 does not have that implementation. Recently Peng Wu fixed ForwardKeyEvent issue in Qt5; https://codereview.qt-project.org/#/c/212179/

fujiwarat commented 6 years ago

CC'ing @epico

juhp commented 6 years ago

Ping? :)

changwoo commented 6 years ago

Recently Peng Wu fixed ForwardKeyEvent issue in Qt5; https://codereview.qt-project.org/#/c/212179/

I found this patch has been applied in Debian but still ForwardKeyEvent doesn't seem to work.

fujiwarat commented 6 years ago

@changwoo You need to have https://github.com/choehwanjin/ibus-hangul/commit/5f7813ea5b303d5f7b43a9fe3a111c706c32a876

changwoo commented 6 years ago

@fujiwarat I already have the ibus-hangul git version packaged in Debian. In Qt apps, nothing happens when I press non-IM keys, as if there's no ForwardKeyEvent implementation.

changwoo commented 6 years ago

@fujiwarat I already have the ibus-hangul git version packaged in Debian. In Qt apps, nothing happens when I press non-IM keys, as if there's no ForwardKeyEvent implementation.

My mistake. It needs from Qt 5.11 from Debian experimental, released May 22.

epico commented 6 years ago

Any progress? :)

choehwanjin commented 6 years ago

Okay, I will release a new version soon.

changwoo commented 6 years ago

I finally tried Qt apps, virtualbox and telegram-desktop, under Qt 5.11, I successfully got space when I press space key. Yeay! But I got full-width characters "(rqts" when I pressed backspace and arrow keys. I'm still finding what is wrong.

changwoo commented 6 years ago

full-width characters "(rqts" when I pressed backspace and arrow keys.

@fujiwarat I think the Qt ForwardKeyEvent patch needs conversion from ibus key codes to qt key codes. ASCII-printable keycodes are the same but other special key codes seems to be different.

choehwanjin commented 6 years ago

I've released a new version 1.5.1. https://github.com/libhangul/ibus-hangul/releases/tag/1.5.1