libhangul / nabi

Nabi - The Easy Hangul XIM
https://github.com/libhangul/nabi/wiki
GNU General Public License v2.0
45 stars 6 forks source link

handler.c:142:14: error: implicit declaration of function 'nabi_ic_lookup_keysym' is invalid in C99 #4

Closed barracuda156 closed 2 years ago

barracuda156 commented 2 years ago

So I am updating nabi in Macports too, and Intel build fails on MacOS 12:

handler.c:142:14: error: implicit declaration of function 'nabi_ic_lookup_keysym' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
keysym = nabi_ic_lookup_keysym(ic, kevent);
              ^

Log here: https://github.com/macports/macports-ports/runs/7888565908 (On 10.6.8 Rosetta I did not get this error.)

Perhaps I could just cut out -Werror flag, but maybe it is better to fix it some other way.

choehwanjin commented 2 years ago

This issue has already been fixed in git version(11f55b4de0db41faff21f35f22b4ff17a52ef741). I will release new version soon.

barracuda156 commented 2 years ago

This issue has already been fixed in git version(11f55b4de0db41faff21f35f22b4ff17a52ef741).

I will release new version soon.

@choehwanjin UPD: I decided to just use a patch from your commit to existing release version, and it solved the problem. (Will be easier to update to the next release, just dropping a patch.)

Thank you!