search

libical / XbICalendar

Objective-C Wrapper for the libical library
Other
17 stars 19 forks source link

Framework-specific project #40

Closed JosephDuffy closed 8 years ago

JosephDuffy commented 8 years ago

I've created a fork of this repository and modified it to produce a framework, which can then be include in iOS (including Swift) applications. I have also recompiled the static library with bitcode enabled and updated the scripts.

I just wanted to let you guys know that I've done this because:

https://github.com/JosephDuffy/XbICalendar

ahalls commented 8 years ago

Joseph Duffy, Just reading through your commentary this is a great contribution to the project. I would be happy to review a pull request in more detail and bring your changes into the project.

There are no active changes going as far as I’m aware so feel free to modify the example app, etc …

The Mozilla Public License support commercial use.

-- Andrew

Mobile Apps To Engage Your Audience

Eagle, Colorado | Mandurah, Western Australia +1 (301) 404 7263 andrew@galtsoft.com mailto:andrew@galtsoft.com www.linkedin.com/in/ahalls http://www.linkedin.com/in/ahalls

On Dec 9, 2015, at 4:32 PM, Joseph Duffy notifications@github.com wrote:

I've created a fork of this repository https://github.com/JosephDuffy/XbICalendar and modified it to produce a framework, which can then be include in iOS (including Swift) applications. I have also recompiled the static library with bitcode enabled and updated the scripts.

I just wanted to let you guys know that I've done this because:

I'd like re-add the app and test targets and code, but they seemed slightly out of date I wanted to make sure there wasn't a project aim I was missing? I'd like to make sure I've got the licensing correct, and that I can use the linked project in a closed-source commercial application? https://github.com/JosephDuffy/XbICalendar https://github.com/JosephDuffy/XbICalendar — Reply to this email directly or view it on GitHub https://github.com/libical/XbICalendar/issues/40.

JosephDuffy commented 8 years ago

Thank you for the reply Andrew. I'm working on getting a new beta of the app this framework is in finished and released so I can find any little bugs along the way.

I'll look at re-adding the app and tests project and then create a pull request with the changes.

Thank you for creating this project. It's saved me a lot of time and headaches!

I'll close this comment for now and open a pull request in the future.

epologee commented 8 years ago

Did you ever get around to creating a pull request with the bitcode enabled libical?

ahalls commented 8 years ago

I haven’t seen it ?

-- A

On Jan 13, 2016, at 7:32 AM, Eric-Paul Lecluse notifications@github.com wrote:

Did you ever get around to creating a pull request with the bitcode enabled libical?

— Reply to this email directly or view it on GitHub https://github.com/libical/XbICalendar/issues/40#issuecomment-171308287.

JosephDuffy commented 8 years ago

I've not had time to properly merge the code so that the current project (as hosted here) would continue to function. My fork is still available, which does have the framework with bitcode enabled, but only has that.