search

libical / vzic

A program to convert the IANA (formerly Olson) timezone database files into VTIMEZONE files compatible with the iCalendar (RFC5445) and TZDIST (RFC7808) specifications
Other
16 stars 14 forks source link

“Zone description not found for: Etc/GMT-2” but output file Etc/GMT-2.ics looks good #9

Closed dilyanpalauzov closed 2 years ago

dilyanpalauzov commented 4 years ago

Running vzic --pure --olson-dir tzdb-2019c --output-dir A prints

Zone description not found for: CET
Zone description not found for: CST6CDT
Zone description not found for: EET
Zone description not found for: EST
Zone description not found for: EST5EDT
Zone description not found for: Etc/GMT
Zone description not found for: Etc/GMT+1
Zone description not found for: Etc/GMT+10
Zone description not found for: Etc/GMT+11
Zone description not found for: Etc/GMT+12
Zone description not found for: Etc/GMT+2
Zone description not found for: Etc/GMT+3
Zone description not found for: Etc/GMT+4
Zone description not found for: Etc/GMT+5
Zone description not found for: Etc/GMT+6
Zone description not found for: Etc/GMT+7
Zone description not found for: Etc/GMT+8
Zone description not found for: Etc/GMT+9
Zone description not found for: Etc/GMT-1
Zone description not found for: Etc/GMT-10
Zone description not found for: Etc/GMT-11
Zone description not found for: Etc/GMT-12
Zone description not found for: Etc/GMT-13
Zone description not found for: Etc/GMT-14
Zone description not found for: Etc/GMT-2
Zone description not found for: Etc/GMT-3
Zone description not found for: Etc/GMT-4
Zone description not found for: Etc/GMT-5
Zone description not found for: Etc/GMT-6
Zone description not found for: Etc/GMT-7
Zone description not found for: Etc/GMT-8
Zone description not found for: Etc/GMT-9
Zone description not found for: Etc/UTC
Zone description not found for: HST
Zone description not found for: MET
Zone description not found for: MST
Zone description not found for: MST7MDT
Zone description not found for: PST8PDT
Zone description not found for: WET

but creates Etc/GMT-2.ics with content:

BEGIN:VCALENDAR
PRODID:-//citadel.org//NONSGML Citadel calendar//EN
VERSION:2.0
BEGIN:VTIMEZONE
TZID:/citadel.org/20200311_1/Etc/GMT-2
LAST-MODIFIED:20200311T102343Z
X-LIC-LOCATION:Etc/GMT-2
X-PROLEPTIC-TZNAME:+02
BEGIN:STANDARD
TZNAME:+02
TZOFFSETFROM:+0200
TZOFFSETTO:+0200
DTSTART:16010101T000000
END:STANDARD
END:VTIMEZONE
END:VCALENDAR

It is unclear to me how to handle the error message from vzic, when the output seems correct.

minichma commented 2 years ago

This message seems to be related to the generation of a zones.tab file. To my understanding it says, that there is no geolocation information available for the mentioned zones, probably because they are not contained in the original zones.tab file. As a consequence only the name is duped into the generated zones.tab.

I'm not sure, whether this s a real problem or not. The code comments says

/*
 * These functions are for dumping all the parsed Zones and Rules to
 * files, to be compared with the output of vzic-dump.pl to check our parsing
 * code is OK. Some of the functions are also used for producing debugging
 * output.
 */

This suggests, that it has no real life relevance. In this case we should just remove the warning. Not sure, whether the generated file is intended to be used by end users.

@winterz Can you/who can comment on this?

winterz commented 2 years ago

I think we can remove the warning You're analysis is 100% correct.