search

libimobiledevice / libplist

A library to handle Apple Property List format in binary or XML
https://libimobiledevice.org
GNU Lesser General Public License v2.1
535 stars 304 forks source link

Fix a few leaks #121

Closed hadess closed 6 years ago

hadess commented 6 years ago

2 memleak fixes discovered through Coverity.

nikias commented 6 years ago

The change in xplist.c will cause multiple checks to fail. The fix looked straight forward to me but I think it's not that simple.

hadess commented 6 years ago

The change in xplist.c will cause multiple checks to fail. The fix looked straight forward to me but I think it's not that simple.

Did you find that out by running the test suite? I can try to figure out what it would take to fix it.

Is the other patch ok?

nikias commented 6 years ago

Yes, make check revealed it. The other patch is fine.

hadess commented 6 years ago

Couldn't figure out what the problem was after staring at it for a while. I've fixed a typo instead, and filed #122 about it.