libimobiledevice / libplist

A library to handle Apple Property List format in binary or XML
https://libimobiledevice.org
GNU Lesser General Public License v2.1
528 stars 304 forks source link

No autogen.sh in release file #251

Closed My1 closed 5 months ago

My1 commented 6 months ago

not really much to say except that the readme calls for it, but the release does not have it.

mast3rz3ro commented 5 months ago

Hi,

You can compile the release version by directly using configure.ac instead of autogen.sh

Try this: ./configure

Please close this issue if your issue is solved.

My1 commented 5 months ago

if that's the case I would call this a documentation issue and should maybe be added to the readme.

mast3rz3ro commented 5 months ago

If you were a familiar with compiling then you wouldn't face this issue, also the readme file in this repo already contains the instructions for building the source code.

Please don't forget to close the issue if your issue is solved.

My1 commented 5 months ago

I am a bit familiar with it but not all things have asked for ./configure, so I am not sure where to use configure especially if there are instructions attached, might be useful to either make the next release with the sh file or with updated instructions, as not everyone is a professional builder of stuff

nikias commented 5 months ago

The readme is referring to building it from source checked out from git, not a source tarball. The release tar.bz indeed doesn't have an autogen.sh as it is in a state that already ran autogen.sh (this is produced using make dist or make distcheck.

My1 commented 5 months ago

would it make sense if the readme inside the release would mention that? not sure how many people build this for what I basically just stumbled on this while i was trying to deal with the dependency fun of idevicerestore

nikias commented 5 months ago

I figured I should maybe just put the autogen.sh inside the archive...

nikias commented 5 months ago

Updated the README to reflect the difference between git source tree and release tarball.