search

libimobiledevice / sbmanager

An GTK/Clutter application to manage SpringBoard icons of an iOS device (INACTIVE)
https://libimobiledevice.org
GNU General Public License v2.0
57 stars 26 forks source link

Update Sbmanager code with code that has fixes for many depreciations in library's used. #2

Closed gitsop01 closed 8 years ago

gitsop01 commented 8 years ago

Still a work in progress due to the changes in Fedora, Gnome 3, Gtk3 and Clutter libraries Although a lot of debugging code and comments are included in the pull request it updates the sbmanager code to remove many library function depreciations and is therefore more up to date.

gitsop01 commented 8 years ago

Thanks for the info about pull request, All comments noted,

nikias commented 8 years ago

This can't be merged as is, as @glensc already stated. We can't accept commits with a commit message "Signed-off-by:" or "Merge branch ***". Every commit needs to make clear what the commit is for. Also commented-out code isn't really what you want in git and you don't actually need that in a version control system anyway.

gitsop01 commented 8 years ago

As @glensc stated the pull should be from  a branch and not off the master. I have noted the comments about the commit messages and the commented out code and will update in a branch.  Would you please close this pull request .

On Fri, 2016-09-30 at 12:48 -0700, Nikias Bassen wrote:

This can't be merged as is, as @glensc already stated. We can't accept commits with a commit message "Signed-off-by:" or "Merge branch ***".

Every commit needs to make clear what the commit is for.

Also commented-out code isn't really what you want in git and you don't actually need that in a version control system anyway.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

     

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c 55493e4bb","name":"GitHub"},"entity":{"external_key":"github/libimob iledevice/sbmanager","title":"libimobiledevice/sbmanager","subtitle" :"GitHub repository","main_image_url":"https://cloud.githubuserconte nt.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc- 7290892c7bb5.png","avatar_image_url":"https://cloud.githubuserconten t.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed- b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/libimobiledevice/sbmanager"}},"upd ates":{"snippets":[{"icon":"PERSON","message":"@nikias in #2: This can't be merged as is, as @glensc already stated. We can't accept commits with a commit message \"Signed-off-by:\" or \"Merge branch ***\".\r\nEvery commit needs to make clear what the commit is for.\r\nAlso commented-out code isn't really what you want in git and you don't actually need that in a version control system anyway."}],"action":{"name":"View Pull Request","url":"https://github.com/libimobiledevice/sbmanager/pull/2

issuecomment-250835964"}}}

glensc commented 8 years ago

@gitsop01 you as author of the PR can close PR yourself.

gitsop01 commented 8 years ago

Pull request closed as code requires clean-up and pulling from a branch.