search

libindic / soundex

Soundex Phonetic Code Algorithm Demo for Indian Languages. Supports all indian languages and English. Provides intra-indic string comparison
GNU Lesser General Public License v3.0
55 stars 12 forks source link

Issue#9 regarding incorrect results is now resolved. #12

Closed arushidogra closed 8 years ago

arushidogra commented 8 years ago

Issue#9 regarding incorrect results is now resolved. Everything is working properly. screenshot from 2016-03-08 15 55 34 screenshot from 2016-03-08 15 55 47 screenshot from 2016-03-08 15 56 00

arushidogra commented 8 years ago

@copyninja , I have made PR for development branch. Can you look into this?

copyninja commented 8 years ago

@arushidogra Please use some meaningful messages in commit. All commit have same messages

arushidogra commented 8 years ago

@copyninja, Should I make a PR with meaningful messages in commits?

stultus commented 8 years ago

@copyninja, Should I make a PR with meaningful messages in commits?

@arushidogra Yes. the purpose of version controlling is to go back to a particular state when we want. If we cannot pinpoint a particular commit using the commit message, there is no point in that.

arushidogra commented 8 years ago

@copyninja I have done the changes.

copyninja commented 8 years ago

@arushidogra This is not acceptable reason being we have 3 + 3 commits which are contradicting each other. I would suggest do fresh clone apply changes there also keep note of what @stultus said.

arushidogra commented 8 years ago

@copyninja , okay i will do the changes. The new commits are same .. only difference is the comments were not added properly in the previous commits.. I will make a PR again with the changes.

copyninja commented 8 years ago

On Wed, Mar 9, 2016 at 2:29 PM, Arushi Dogra notifications@github.com wrote:

@copyninja , okay i will do the changes. The new commits are same .. only difference is the comments were not added properly in the previous commits.. I will make a PR again with the changes.

Actually with your new commits we do not get the feature of reverting single change as mentioned by @stultus.

Vasudev Kamath http://copyninja.info copyninja@{frndk.de|vasudev.homelinux.net}

copyninja commented 8 years ago

Closing this PR as you already gave a different PR