search

libitx / txforge

Modern Bitcoin transaction builder, capable of supporting any non-standard and custom script type.
Apache License 2.0
64 stars 22 forks source link

Transaction Version Number #6

Closed sirdeggen closed 3 years ago

sirdeggen commented 3 years ago

Sometimes TxForge creates transactions which have their version byte set to 00 rather than 01.

I cannot figure out why (so far).

sirdeggen commented 3 years ago

Further investigation reveals that at some point it is being replaced with nLocktime. When inspecting the object after adding inputs and signing:

versionBytesNum: {nLockTime: undefined}

libitx commented 3 years ago

Thanks for reporting this @sirdeggen I may have inadvertantly introduced this with the latest release which enabled setting nlocktime on the txforge instance.

If its causing issues, revert to version 0.1.7 whilst I dig in to this.

libitx commented 3 years ago

This is fixed now. Please upgrade to version 0.1.10.