search

libkeepass / pykeepass

Python library to interact with keepass databases (supports KDBX3 and KDBX4)
https://pypi.org/project/pykeepass/
GNU General Public License v3.0
403 stars 96 forks source link

Return `None` if `deref` encouters a broken reference (fixes #384) #386

Closed br-olf closed 3 months ago

br-olf commented 4 months ago

Hi I tried to fix the issue #384 and wrote a small test but I didn't mess with the test databases so I used add_entry and delete_entry to set up my testcase. If a reference is broken the code will now just return None and won't raise an exception. I think this is better and can be caught easily by the caller of deref.

A6GibKm commented 3 months ago

Please give the PR and commit a more descriptive title.

Please also add to end of the commit description

Fixes: https://github.com/libkeepass/pykeepass/issues/384
br-olf commented 3 months ago

Done :)

Evidlo commented 3 months ago

Thanks for the fix.