liblouis / liblouisutdml

An open-source library providing complete braille transcription services for xml, html and text documents
http://liblouis.io
GNU General Public License v3.0
24 stars 16 forks source link

Update MathML processing code and tests so that it works with file2brl #87

Closed NSoiffer closed 1 year ago

bertfrees commented 1 year ago

Hi @NSoiffer,

There is something I don't quite get. The Github Actions system tells us that the test suite worked fine, but your commit https://github.com/liblouis/liblouisutdml/pull/87/commits/451c74cf9d7c788de58e5cd572a9de9b8e3b7dc7 made it fail. So I don't see how this is an improvement. Are you saying that on your system the test suite didn't work before and now it works?

Your last commit which adds the many new tests is of course great.

I'm thinking about how we can move these tests to Liblouis (like we did for UEB in https://github.com/liblouis/liblouis/pull/1310), so that we can move nemeth.ctb back to Liblouis also (https://github.com/liblouis/liblouis/issues/815). The problem is that I can not simply use the approach of https://github.com/liblouis/liblouis/pull/1310 because nemeth.ctb is designed for use with nemeth.sem, not mathml.xsl. I have two options:

hammera commented 1 year ago

Hi,

In tests/mathml_nemeth/liblouisutdml.ini I need do following modification to works the test system: Need change the ../lbu_files path with ../../lbu_files to works the test system again. Note: Because previous the edit table used en-us-brf.dis file 31 nemeth tests failed, because the expected.txt contains usa braille output, not unicode Braille output.

Attila

hammera commented 1 year ago

@NSoiffer, I forgot a thing: Matrix line not need comment out with lbu_files/nemeth.sem file. In tests/mathml_nemeth/styles.cfg enough put following modification to liblouis not drop error message the undefined matrix style related when file2brl examine your tests:

style matrix
    format alignColumnsLeft

Bert, possible happen checking error because not good the tests/mathml_nemeth/liblouis.ini the table path variables, and mismatch .github/workflow/sanitizer.yml file the Liblouis version? The .github/workflow/main.yml file we migrated with Liblouis 3.26.0 version, but forgot doing this migration the .github/workflow/sanitizer.yml file. Default the sanitizer.yml file contains Liblouis 3.21 version.

When I working @norbertmarkus the #96 related pull request in monday, we experienced similar check results with first time.

Hope this help,

Attila

egli commented 1 year ago

Has been superseded by #98