libmir / mir-algorithm

Dlang Core Library
http://mir-algorithm.libmir.org
Other
173 stars 37 forks source link

32 bit windows LDC build fails #461

Closed WebFreak001 closed 6 months ago

WebFreak001 commented 1 year ago

Trying to build 32 bit windows build with mir-algorithm as dependency:

    Building mir-algorithm 3.18.4: building configuration [default]
C:\Users\runneradmin\AppData\Local\dub\packages\mir-algorithm-3.18.4\mir-algorithm\source\mir\bignum\internal\phobos_kernel.d(57,23): Error: version `HaveAsmVersion` defined after use
Error ldc2 failed with exit code 1.

See https://github.com/Pure-D/serve-d/actions/runs/4528748421/jobs/7975811435

veelo commented 6 months ago

Still an issue in release v3.21.0.

thewilsonator commented 6 months ago

@veelo are you able to test if this works with the master branch of this repo? e888555 (Aug 9 2023) made some changes to that line but was done after v3.21.0 (Aug 2 2023). I believe that commit should fix the issue (versions are evaluated before static if, so that may well lead to definition after use)

@9il either way this will need a new release tag

veelo commented 6 months ago

Indeed, a dependency of "mir-algorithm": "~master" does work at the moment. Thanks!

thewilsonator commented 6 months ago

Thanks for the confirmation

9il commented 6 months ago

Thank you all, v3.22.0

thewilsonator commented 6 months ago

Fixed in v3.22.0