search

libmir / mir-stat

Dlang Statistical Package
http://mir-stat.libmir.org/
Other
12 stars 3 forks source link

Add geometric distribution & additional fixes #58

Closed jmh530 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #58 (4fb807e) into master (bbeb4ca) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   99.89%   99.92%   +0.03%     
==========================================
  Files          20       21       +1     
  Lines        2733     2804      +71     
==========================================
+ Hits         2730     2802      +72     
+ Misses          3        2       -1
Impacted Files Coverage Δ
source/mir/stat/distribution/chi2.d 100.00% <100.00%> (ø)
source/mir/stat/distribution/gamma.d 100.00% <100.00%> (+0.74%) :arrow_up:
source/mir/stat/distribution/geometric.d 100.00% <100.00%> (ø)
source/mir/stat/distribution/poisson.d 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbeb4ca...4fb807e. Read the comment docs.

9il commented 2 years ago

why the diff is so huge?

jmh530 commented 2 years ago

Might be easier to look at it on a commit by commit basis. Some of them are pretty trivial and the diff just looks big because I'm reordering how some things appear. For instance, it is easier for me to see what is missing when they are in alphabetical order.

On Wed, Jul 20, 2022 at 1:55 PM Ilia Ki @.***> wrote:

why the diff is so huge?

— Reply to this email directly, view it on GitHub https://github.com/libmir/mir-stat/pull/58#issuecomment-1190582472, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADBFNSTDZGVLKQXSPUQBJXTVVA4P7ANCNFSM54B2A5TA . You are receiving this because you authored the thread.Message ID: @.***>

9il commented 2 years ago

Take the index.d for example. The diff is the whole file. https://github.com/libmir/mir-stat/pull/58/files#diff-ec1aab9dc4cea66c5e2b284f0aff80d1475b6f534411b46015e6a1e435789198

jmh530 commented 2 years ago

@9il The issue may be related to Windows vs. Unix line endings. I will try to fix when I have time, but it might be a few days.

jmh530 commented 2 years ago

@9il Fixed.