libnano / primer3-py

Simple oligo analysis and primer design
https://libnano.github.io/primer3-py
GNU General Public License v2.0
169 stars 44 forks source link

Windows compile fail #37

Closed wpwupingwp closed 4 years ago

wpwupingwp commented 4 years ago

Build in Windows 10 with Python 3.8:

ValueError: path '/Users/ben/gitrepos/primer3-py/primer3/src/primerdesign_helpers.c' cannot be absolute

Then I found that, in primer3_py.egg-info/SOURCES.txt, there are

/Users/ben/gitrepos/primer3-py/primer3/src/primerdesign_helpers.c
/Users/ben/gitrepos/primer3-py/primer3/src/libprimer3/dpal.c
/Users/ben/gitrepos/primer3-py/primer3/src/libprimer3/libprimer3.c
/Users/ben/gitrepos/primer3-py/primer3/src/libprimer3/oligotm.c
/Users/ben/gitrepos/primer3-py/primer3/src/libprimer3/p3_seq_lib.c
/Users/ben/gitrepos/primer3-py/primer3/src/libprimer3/thal.c

After change it to

primer3/src/primerdesign_helpers.c
primer3/src/libprimer3/dpal.c
primer3/src/libprimer3/libprimer3.c
primer3/src/libprimer3/oligotm.c
primer3/src/libprimer3/p3_seq_lib.c
primer3/src/libprimer3/thal.c

the build succeed.

So, please consider to remove absolute path in SOURCES.txt :smiley:

Ping Wu

wpwupingwp commented 4 years ago

The source code was acquired by

pip download primer3-py

and the version is 0.6.0

wpwupingwp commented 4 years ago

primer3_py-0.6.0-cp38-cp38-win_amd64.whl.zip

Also, this is wheel file for Python 3.8 on Windows (zipped because github do not support .whl), which is not available on pip now. Hope it could make some contribution :smiley: