search

libnano / primer3-py

Simple oligo analysis and primer design
https://libnano.github.io/primer3-py
GNU General Public License v2.0
157 stars 43 forks source link

Building the sdist fails as header is missing : v1.1.0 #95

Closed ccoulombe closed 1 year ago

ccoulombe commented 1 year ago

Building from source from the sdist on PyPI fails as the dpal.h header is missing:

      primer3/src/libprimer3/dpal.c:43:10: fatal error: dpal.h: No such file or directory
         43 | #include "dpal.h"
            |          ^~~~~~~~

Building/installing from Github works :

pip install https://github.com/libnano/primer3-py/archive/refs/tags/v1.1.0.tar.gz
benpruitt commented 1 year ago

I believe @grinner already caught and fixed this (see https://github.com/libnano/primer3-py/pull/92/files#diff-60f61ab7a8d1910d86d9fda2261620314edcae5894d5aaa236b821c7256badd7R90) -- should be addressed in the 1.2.0 release, which should come out in the not-too-distant future (the referenced commit is already merged into the 1.2.0 staging branch)

(note that the commit references conda but the inclusion of dpal.h and other header/source files in the package_data should address the issue that you're running into @ccoulombe)

ccoulombe commented 1 year ago

Excellent, thanks @benpruitt !

We avoid conda as the pest but looking at the commit this will work with a standard virtual environment and pip install. In all cases, I can build wheels from the Github sources as well.

I can confirm once the v1.2.0 is released.

grinner commented 1 year ago

PR #98 for 1.2.0 fixes this issue