search

libnonius / nonius

A C++ micro-benchmarking framework
https://nonius.io
Creative Commons Zero v1.0 Universal
358 stars 47 forks source link

Directly construct stringstream without copy/move #104

Open tbleher opened 6 years ago

tbleher commented 6 years ago

The libstdc++ bundled with G++ 4.8.1 on OpenSUSE 13.1 does not have a move constructor for std::stringstream, and copying is forbidden. Work around this by constructing the std::stringstream directly.

michalfita commented 5 years ago

GCC 4.8.1 has been released May 31, 2013. That's more than 5 years ago, an era in compilers development. Does it really make sense to contaminate the style of the library with such minor fix?

mquinson commented 5 years ago

The change is so small that I'd hardly call it a style contamination, would you?

michalfita commented 5 years ago

It is small. However, in my personal opinion not worth the hassle. You already solved the problem for yourself, highly unlikely ever going to use never version of nonius (last release two years ago).

I understand the importance of it for you, but looking at other PR's the average time to get merged being about two years I would abandon the hope.

tbleher commented 5 years ago

I understand that people are reluctant to support old compilers, but the fact is that these systems are still in use (otherwise I would not report that issue). I can understand that people do not want to chase bug reports for old systems, but this is different: this is a very simple fix for a concrete problem that can be applied immediately. Honestly I cannot see any "contamination". Surely the authors of nonius published nonius in the hope that people would use it. This patch helps people use the library. What's gained by not accepting this patch?