search

libntl / ntl

258 stars 51 forks source link

fix bug. when gmp version is 6.2.1 #5

Open zjwangmin opened 3 years ago

zjwangmin commented 3 years ago

fix bug. when gmp version is bigger than 6.0.0. gmp current version is 6.2.1.

victorshoup commented 3 years ago

Hi! Thanks for the PR. I'm not sure your modification makes sense. The point of that test is to check if the version number in the GMP header file is identical to that in the GMP binaries. If they are not, that is is a sign that there is some inconsistency in your system configuration. For example, you might have things set up so that the compiler sees certain header files, but you might not have environment variables set up to see the corresponding library a run time. So...I'm not sure that changing the comparison from != to < makes sense. But perhaps you have an argument to support your proposal...please let me know...I'd be happy to discuss!

zjwangmin commented 3 years ago

Hi Libntl/Ntl,

Thanks for your reply. I think I got some wrong. Thank you very much.

Many Thanks, Min Wang.

On Mon, Apr 26, 2021 at 8:30 PM victorshoup @.***> wrote:

Hi! Thanks for the PR. I'm not sure your modification makes sense. The point of that test is to check if the version number in the GMP header file is identical to that in the GMP binaries. If they are not, that is is a sign that there is some inconsistency in your system configuration. For example, you might have things set up so that the compiler sees certain header files, but you might not have environment variables set up to see the corresponding library a run time. So...I'm not sure that changing the comparison from != to < makes sense. But perhaps you have an argument to support your proposal...please let me know...I'd be happy to discuss!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/libntl/ntl/pull/5#issuecomment-826796822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAH5LWVOO4QDSOCTHTA2IZDTKVMH7ANCNFSM43R6XG6A .