search

libnxz / power-gzip

POWER NX zlib compliant library
23 stars 18 forks source link

inflateSetDictionary and deflateSetDictonary are failing #15

Closed rzinsly closed 2 years ago

rzinsly commented 4 years ago

Per https://github.com/libnxz/power-gzip/pull/13#issuecomment-619103574 SetDictonary functions are failing with some data.

We need a proper unit test to ensure data don't get corrupted, ideally using zlib to compare. i.e. compressing with zlib, decompressing with nx and vice versa.

lucmaga commented 2 years ago

Do we have a dictionary file that reproduces the error?

rzinsly commented 2 years ago

I wasn't able to reproduce it, @abalib do you still have the data you had for #13?

mscastanho commented 2 years ago

Fixed by #140