search

libnxz / power-gzip

POWER NX zlib compliant library
23 stars 18 forks source link

Fix issue 84 #89

Closed tuliom closed 3 years ago

tuliom commented 3 years ago
  1. Implement the early return as reported in issue #84 .
  2. More cosmetic changes.
lucmaga commented 3 years ago

This exposes that we need a test for sizes smaller than the soft_copy_threshold.

tuliom commented 3 years ago

This exposes that we need a test for sizes smaller than the soft_copy_threshold.

While I agree with this, this issue is actually exposing errors in the test itself. I have fixed that and added new tests which are exposing more errors.

tuliom commented 3 years ago

@mscastanho , @lucmaga I included a new test short arrays and fixed 2 issues with the tests.

mscastanho commented 3 years ago

(GitHub messed up my review comments on individual commits, posting again here)

@tuliom There are other _test_deflate functions on test_[multithread_]stress.c that should also be changed to use the pointer to comprLen, to keep things consistent.

tuliom commented 3 years ago

There are other _testdeflate functions on test[multithread_]stress.c that should also be changed to use the pointer to comprLen, to keep things consistent.

@mscastanho test_multithread_stress.c is not affected because it uses the compress|uncompress API.

I modified test_stress.c in the last version of this PR.