search

libnxz / power-gzip

POWER NX zlib compliant library
23 stars 18 forks source link

Minor fixes #94

Closed tuliom closed 3 years ago

tuliom commented 3 years ago
  1. Remove 3 configuration variables that are not functional at the moment.
  2. Add more files to .gitignore.
  3. Fix db2.souce in oct/.
rzinsly commented 3 years ago 
* There is one use of `NX_GZIP_CSB_POLL_MAX` left that should be removed as well
  https://github.com/libnxz/power-gzip/blob/828e9ee6354de3886f5bc33348469a914261dfd6/test/run_system_check.sh#L9

* Same for `NX_GZIP_PASTE_RETRIES`
  https://github.com/libnxz/power-gzip/blob/828e9ee6354de3886f5bc33348469a914261dfd6/samples/run-series.sh#L46

@mscastanho Good catch, I forgot about these. IMO we can remove the entire checkstop test as it only happens with the old patched kernels, no one should be using that as we have the NX patches included since 5.8. The kernel oops check could still be useful, but the csb poll max is not being used in the code.

rzinsly commented 3 years ago

The kernel oops check could still be useful, but the csb poll max is not being used in the code.

The sleeping code for wait_for_csb() was improved and is not "polling" anymore, the kernel oops test is not doing anything different than test_stress It could be entirely removed as well.

tuliom commented 3 years ago

I removed both usages. Thanks! After a chat with @rzinsly , we decided to leave the checkstop test.

I ended up including 2 more patches:

  1. Fixing issue #56
  2. Increasing the number of tests with short arrays for inflate().