libo26 / feedparser

Automatically exported from code.google.com/p/feedparser
Other
0 stars 0 forks source link

monkey-patching sgmllib breaks other libraries #271

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. import feedparser, use any other library relying on sgmllib
2. do not import import feedparser, use any other library relying on sgmllib
3. the results may be different

feedparser replaces sgmllib.endbracket for every other library.

This causes this bug (with Mechanize): https://symlink.me/issues/649 which is 
present only when feedparser is imported.

Original issue reported on code.google.com by pankk...@gmail.com on 23 Apr 2011 at 12:32

GoogleCodeExporter commented 9 years ago
I think I've fixed this in a github branch at:

https://github.com/kurtmckee/feedparser/tree/issue271

I'd really appreciate it if you would test the code (direct link below) and 
report back if it fixes the Mechanize issue you mentioned above.

https://github.com/kurtmckee/feedparser/raw/6d5ce55395732672f982f7cb7bc026bb54e6
3f23/feedparser/feedparser.py

Original comment by kurtmckee on 15 May 2011 at 7:33

GoogleCodeExporter commented 9 years ago
This is fixed in r553.

Original comment by kurtmckee on 29 May 2011 at 7:00