libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.
https://libocca.org
MIT License
393 stars 86 forks source link

libCEED Travis CI With OCCA Now Failing #198

Closed jeremylt closed 6 years ago

jeremylt commented 6 years ago

A recent update to OCCA now gives a failure in Travis for OCCA for all examples, CEED, MFEM, and PETSc. I suspect there is a change that needs to get updated in our OCCA backends

PR Link with failing Travis: https://github.com/CEED/libCEED/pull/143

jeremylt commented 6 years ago

This commit works with libCEED

https://github.com/libocca/occa/commit/527494c949e95451f491c710592e9cd91e52b56f

dmed256 commented 6 years ago

My bad, accidentally pushed a bad commit to master

jeremylt commented 6 years ago

No worries. I just wanted to make sure you knew because it could have been something we needed to adjust on our end.

jeremylt commented 6 years ago

I'm still seeing the issue. I made a PR for libCEED that runs Travis against the last version of OCCA that libCEED passes with.

https://github.com/CEED/libCEED/pull/145

dmed256 commented 6 years ago

Oops, misread the hash. Thought it was the HEAD commit at the time. I'll check this tonight, my bad

jeremylt commented 6 years ago

No worries, thanks for looking into it

dmed256 commented 6 years ago

@jeremylt seems the new kernelHash method is messing something up

https://github.com/libocca/occa/blob/master/src/device.cpp#L442

Changing it back to occa::hash(allProps) seems to make libCEED tests pass again. I'll keep looking to find out the root cause, just wanted to update you on that

v-dobrev commented 6 years ago

By the way, @dmed256, I think this issue also affects mfem's engines-dev branch and probably occa-dev as well.

jeremylt commented 6 years ago

Thanks for the update!

dmed256 commented 6 years ago

@jeremylt @v-dobrev Just tested libCEED with origin/master (1450f7420484e984adc57ab5df070bd03c0ccbb8) and it passes again

v-dobrev commented 6 years ago

Thanks, David! I'll give it a try with mfem.

v-dobrev commented 6 years ago

The latest commit (https://github.com/libocca/occa/commit/780a06ae273ea037bf21452600ffdb17b93a312c) works OK with mfem (engines-dev).