search

libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.
https://libocca.org
MIT License
396 stars 86 forks source link

Increase the number of arguments to kernels #671

Closed deukhyun-cha closed 1 year ago

deukhyun-cha commented 1 year ago

Asking for this change to be made that we had a case for a compute kernel requires passing more arguments than currently defined. Although passing this many arguments seems to be rare, there can be a situation beneficial to consolidate multiple kernels which shares major portion of the codes but with small variations (in terms of code management). The code body can be easily distinguished by kernel defines without losing the performance, but sometimes each variation requires different arguments that makes the number of arguments increase.

codecov[bot] commented 1 year ago

Codecov Report

Merging #671 (91ee782) into development (5790d72) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head 91ee782 differs from pull request most recent head 9255801. Consider uploading reports for the commit 9255801 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/libocca/occa/pull/671/graphs/tree.svg?width=650&height=150&src=pr&token=doaG4c84wZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)](https://codecov.io/gh/libocca/occa/pull/671?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) ```diff @@ Coverage Diff @@ ## development #671 +/- ## ============================================ Coverage 76.27% 76.27% ============================================ Files 291 291 Lines 18785 18787 +2 ============================================ + Hits 14328 14330 +2 Misses 4457 4457 ``` [see 2 files with indirect coverage changes](https://codecov.io/gh/libocca/occa/pull/671/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)