search

libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.
https://libocca.org
MIT License
389 stars 82 forks source link

[HIP] Hip updates #677

Closed noelchalmers closed 1 year ago

noelchalmers commented 1 year ago

Description

Some updates/fixes for HIP.

Some files in the ROCm install are shifting around for ROCm 6.0, and the compiler flag for target arch is changing.

Also, in my noodling with passing structs to kernels by value, I found some problems with how we were packing arguments to the hip kernel launcher. I've fixed those up, but there's still some problems lurking. I'm aware of at least one corner case where we don't align arguments the way the HIP kernel is expecting. I'm going to try and address that on the HIP side, however.

codecov[bot] commented 1 year ago

Codecov Report

Merging #677 (d074928) into development (cbdd074) will increase coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head d074928 differs from pull request most recent head 70bedd5. Consider uploading reports for the commit 70bedd5 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/libocca/occa/pull/677/graphs/tree.svg?width=650&height=150&src=pr&token=doaG4c84wZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)](https://codecov.io/gh/libocca/occa/pull/677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) ```diff @@ Coverage Diff @@ ## development #677 +/- ## ============================================ Coverage 76.23% 76.23% ============================================ Files 291 291 Lines 18798 18800 +2 ============================================ + Hits 14330 14333 +3 + Misses 4468 4467 -1 ``` [see 2 files with indirect coverage changes](https://codecov.io/gh/libocca/occa/pull/677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)