libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.
https://libocca.org
MIT License
389 stars 82 forks source link

OCCA enum and union support #705

Closed kian-ohara closed 1 year ago

kian-ohara commented 1 year ago

Added support for (typedef) enums and (typedef) unions.

mkbosmans commented 1 year ago

We have tested this on our side and it correctly handles enums and unions now in kernel code.

codecov[bot] commented 1 year ago

Codecov Report

Merging #705 (76d62de) into development (adde964) will decrease coverage by 0.99%. The diff coverage is 45.86%.

:exclamation: Current head 76d62de differs from pull request most recent head 84f843e. Consider uploading reports for the commit 84f843e to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/libocca/occa/pull/705/graphs/tree.svg?width=650&height=150&src=pr&token=doaG4c84wZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) ```diff @@ Coverage Diff @@ ## development #705 +/- ## =============================================== - Coverage 76.24% 75.25% -0.99% =============================================== Files 292 297 +5 Lines 18826 19324 +498 =============================================== + Hits 14354 14543 +189 - Misses 4472 4781 +309 ``` | [Files Changed](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) | Coverage Δ | | |---|---|---| | [include/occa/dtype/dtype.hpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-aW5jbHVkZS9vY2NhL2R0eXBlL2R0eXBlLmhwcA==) | `0.00% <0.00%> (ø)` | | | [src/occa/internal/lang/type/typedef.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy90eXBlL3R5cGVkZWYuY3Bw) | `70.37% <ø> (-1.06%)` | :arrow_down: | | [src/occa/internal/lang/type/vartype.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy90eXBlL3ZhcnR5cGUuY3Bw) | `84.52% <28.57%> (-3.30%)` | :arrow_down: | | [src/occa/internal/lang/type/union.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy90eXBlL3VuaW9uLmNwcA==) | `33.96% <29.78%> (+33.96%)` | :arrow_up: | | [src/dtype/dtype.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL2R0eXBlL2R0eXBlLmNwcA==) | `51.67% <35.11%> (-23.67%)` | :arrow_down: | | [src/occa/internal/lang/enumerator.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy9lbnVtZXJhdG9yLmNwcA==) | `36.00% <36.00%> (ø)` | | | [src/occa/internal/lang/type/enum.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy90eXBlL2VudW0uY3Bw) | `40.00% <36.73%> (+40.00%)` | :arrow_up: | | [src/occa/internal/lang/loaders/typeLoader.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy9sb2FkZXJzL3R5cGVMb2FkZXIuY3Bw) | `79.00% <63.51%> (-6.08%)` | :arrow_down: | | [src/occa/internal/lang/loaders/unionLoader.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy9sb2FkZXJzL3VuaW9uTG9hZGVyLmNwcA==) | `64.70% <64.70%> (ø)` | | | [src/occa/internal/lang/loaders/enumLoader.cpp](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca#diff-c3JjL29jY2EvaW50ZXJuYWwvbGFuZy9sb2FkZXJzL2VudW1Mb2FkZXIuY3Bw) | `83.72% <83.72%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/libocca/occa/pull/705?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/libocca/occa/pull/705/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)
mkbosmans commented 1 year ago

Would this be still in time to go in the 1.6 release?