Change HIP_PLATFORM from HCC to AMD and NVCC to NVIDIA

libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.

https://libocca.org

MIT License

382 stars 81 forks source link

Change HIP_PLATFORM from HCC to AMD and NVCC to NVIDIA #713

Closed rakesroy closed 8 months ago

rakesroy commented 8 months ago

Description

In ROCm6.0 HIP runtime is removing HCC, NVCC symbols
Replace __HIP_PLATFORM_HCC with __HIP_PLATFORM_AMD
Replace __HIP_PLATFORM_NVCC with __HIP_PLATFORM_NVIDIA

rakesroy commented 8 months ago

Hi @noelchalmers, The new names are supported from ROCm 4.2 onwards. See https://github.com/ROCm-Developer-Tools/HIP/blob/rocm-4.2.x/include/hip/hip_runtime.h#L59 . We are only removing the deprecated __HIP_PLATFORM_HCC & __HIP_PLATFORM_NVCC in ROCm 6.0 giving users time of almost 2 major releases to migrate to the new macro. So unless you require libocca to work with ROCm 4.1 or earlier you should be good with just __HIP_PLATFORM_AMD & __HIP_PLATFORMNVIDIA.

noelchalmers commented 8 months ago

Thanks for the clarification. In the OCCA README we call our HIP (i.e. ROCm) v3.5 or later is supported. I think it's reasonable to bump this to v4.2.

I'll merge this PR in and make a separate PR to change the version requirement in the README, as well as clean up some places where we are doing some reverse-compatibility switches for ROCm 3.5.