search

libocca / occa

Portable and vendor neutral framework for parallel programming on heterogeneous platforms.
https://libocca.org
MIT License
389 stars 82 forks source link

[HIP] Resize the argument buffer to be able to fit large arguments passed by value #714

Closed noelchalmers closed 10 months ago

noelchalmers commented 11 months ago

Description

Fixes an issue where large (>sizeof(void*)) arguments passed by value in HIP mode would overflow the allocated space for kernel arguments passed to hipModuleLaunchKernel

Thanks to @ooreilly for reporting the issue!

codecov[bot] commented 11 months ago

Codecov Report

Merging #714 (c2fd37d) into development (c3162d8) will not change coverage. The diff coverage is n/a.

:exclamation: Current head c2fd37d differs from pull request most recent head 9af1526. Consider uploading reports for the commit 9af1526 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/libocca/occa/pull/714/graphs/tree.svg?width=650&height=150&src=pr&token=doaG4c84wZ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca)](https://app.codecov.io/gh/libocca/occa/pull/714?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libocca) ```diff @@ Coverage Diff @@ ## development #714 +/- ## ============================================ Coverage 75.26% 75.26% ============================================ Files 297 297 Lines 19324 19324 ============================================ Hits 14544 14544 Misses 4780 4780 ```