libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

[PWX-24665] Modified 'volume detached' condition for DevicePath() API for oracle provider. #117

Closed vinayakshnd closed 2 years ago

vinayakshnd commented 2 years ago

DevicePath() API should return cloudops.ErrVolDetached error in all of the below condition:

  1. VolumeAttachment response have empty list of attachments. []
  2. VolumeAttachment has no details of instance to which it is attached.
  3. VolumeAttachment is in DETACHING or DETACHED state.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional) Closes #

Special notes for your reviewer:

codecov-commenter commented 2 years ago

Codecov Report

Base: 8.26% // Head: 8.25% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (c3ce130) compared to base (662e475). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ========================================= - Coverage 8.26% 8.25% -0.01% ========================================= Files 18 18 Lines 4576 4577 +1 ========================================= Hits 378 378 - Misses 4176 4177 +1 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/libopenstorage/cloudops/pull/117?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage) | Coverage Δ | | |---|---|---| | [oracle/oracle.go](https://codecov.io/gh/libopenstorage/cloudops/pull/117/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage#diff-b3JhY2xlL29yYWNsZS5nbw==) | `6.91% <0.00%> (-0.02%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.