libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

PWX-29069: Handling panic in case of incorrect volume template #131

Closed pp511 closed 1 year ago

pp511 commented 1 year ago

Signed-off-by: Priyanshu Pandey ppandey@purestorage.com

What this PR does / why we need it: Handling panic due to nil DiskProperties when no param is specified in -s

Which issue(s) this PR fixes (optional) Closes #https://portworx.atlassian.net/browse/PWX-29069

Special notes for your reviewer:

codecov-commenter commented 1 year ago

Codecov Report

Base: 8.10% // Head: 8.10% // No change to project coverage :thumbsup:

Coverage data is based on head (f9548d2) compared to base (d65a9e1). Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ====================================== Coverage 8.10% 8.10% ====================================== Files 18 18 Lines 4664 4664 ====================================== Hits 378 378 Misses 4264 4264 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/libopenstorage/cloudops/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage) | Coverage Δ | | |---|---|---| | [azure/azure.go](https://codecov.io/gh/libopenstorage/cloudops/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage#diff-YXp1cmUvYXp1cmUuZ28=) | `0.56% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.