libopenstorage / cloudops

Apache License 2.0
7 stars 13 forks source link

PWX-21520 : Add custom namespace during configmap creation #136

Open nikita-bhatia opened 1 year ago

nikita-bhatia commented 1 year ago

https://portworx.atlassian.net/browse/PWX-21520

Changes done :

Version of sched-ops is changed to latest commit hash to master. Because of that, other versions were also required to be updated and compatibility with Go 1.17 was not there anymore.

P.S : Need to update cloudops version in "porx" go.mod after this PR is merged.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.03 :tada:

Comparison is base (d8c64b7) 8.06% compared to head (86173ac) 8.10%.

:exclamation: Current head 86173ac differs from pull request most recent head d79c665. Consider uploading reports for the commit d79c665 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #136 +/- ## ========================================= + Coverage 8.06% 8.10% +0.03% ========================================= Files 18 18 Lines 4686 4664 -22 ========================================= Hits 378 378 + Misses 4286 4264 -22 Partials 22 22 ``` | [Impacted Files](https://codecov.io/gh/libopenstorage/cloudops/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage) | Coverage Δ | | |---|---|---| | [vsphere/vsphere.go](https://codecov.io/gh/libopenstorage/cloudops/pull/136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage#diff-dnNwaGVyZS92c3BoZXJlLmdv) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=libopenstorage)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nrevanna commented 1 year ago

Had an offline discussion. We want to avoid PX_NAMESPACE usage in all our open-source repos. Nikita will work on removing that from cloud-ops also. Thanks Piyush.