Open rge-pure opened 1 year ago
Patch coverage has no change and project coverage change: -0.50
:warning:
Comparison is base (
9ecda22
) 8.10% compared to head (f040508
) 7.61%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Discussed offline. Summarizing here: Some params like *Encryption can be passed as nil. It won't cause panic but would just end up creating a non encrypted disk. Let's only check for mandatory params Eg: size. type could be a mandatory param in some clouds(not sure which) but is not in AWS as it defaults to gp2.
Thanks Priyanshu for the advice.
What this PR does / why we need it: Following issue was reported on gs-rel 2.13 on Azure PWX-29069. This was related to nil drive size being passed during drive create which was resulting into nil pointer dereference. This was fixed for Azure.
We need to do a thorough check on all the supported cloud platforms supported in cloudops for all the params that can be passed as “nil” that can result into a panic and handle those.
Which issue(s) this PR fixes PWX-29108
Special notes for your reviewer: General Workflow : Be very cautious with nil pointer check, avoid any false-positive
Follow the following rules to detect nil pointer or index out of range
Also, did a go fmt, some changes are based on that.